feat: add BillboardSettings & ThresholdWithSeriesOverrides to Dashboard#1305
feat: add BillboardSettings & ThresholdWithSeriesOverrides to Dashboard#1305jcrengifoa wants to merge 2 commits intonewrelic:mainfrom
Conversation
|
|
|
|
pkg/dashboards/dashboards_types.go
Outdated
There was a problem hiding this comment.
Our general practice is to keep any constants at the top of the file. We recommend using capital letters for constant strings, though you can use lowercase if your API requires it.
There was a problem hiding this comment.
Got it @shashank-reddy-nr, the variables have been moved + changed const in favor of var to further comply with the code standards
shashank-reddy-nr
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1305 +/- ##
==========================================
+ Coverage 35.36% 35.41% +0.05%
==========================================
Files 130 130
Lines 7746 7746
==========================================
+ Hits 2739 2743 +4
+ Misses 4820 4818 -2
+ Partials 187 185 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
No description provided.